Idiom. A "double-edged sword" refers to something that has both favorable and unfavorable consequences.